queenofthenightosphere's Comments
| Changeset | When | Comment |
|---|---|---|
| 170167841 | I know that the wiki says that `contact:housenumber`, `contact:street` etc. are what are usually used, but I feel that it makes much more logical and practical sense to use `contact:addr:*`. |
|
| 170010284 | > mentioning both only makes sense if they are different. I disagree. Stating the `contact` address explicitly is to say with certainty that it is known that it is the correct contact address. If one only has the building address, a user consuming the data won't know for sure if the contact address is the same as the building address — they can only guess that it is the case; however, it's also possible that it was simply unknown to the mapper at the time what the correct contact address is, and it could therefore very well be different than the building address if it wasn't mapped. |
|
| 170036503 | Sure, but if you look at `<small_range_selectors>` under §"Syntax Diagram", it states `[<weekday_selector>][<time_selector>]` without any `<space>`. There's inconsistency between the examples and the spec. |
|
| 170036503 | The addition of that space doesn't seem to follow the opening hours spec: opening_hours=*/specification |
|
| 170010284 | I think it should be both in this case. They specifically mention the address to use to contact them on their website. Addr is used for the physical location, contact is for mailing. I'm aware that they're both the same, but it's important specificity, imo. |
|
| 169850240 | I feel like activity_panel is better than activitypanel. Same thing for climbing_frame vs climbingframe. Same thing for climbingwall vs climbing_wall. Is it not clearer to read with the words appropriately separated? What would be the specific reason to combine them? The playground keys are too inconsistent in their usage of underscores vs no underscores to really outline an established trend imo. It feels like it's better to at least prioritize readability. |
|
| 168221973 | I'm not sure about the tag `toilets:wheelchair:grab_rails=yes`. I feel like I prefer `toilets:grab_rails=yes`. The `wheelchair` namespace seems unnecessary, and somewhat inaccurate. Grab rails aren't only for wheelchairs, and it doesn't feel necessary to namespace them under wheelchairs even if they were. |
|
| 160600374 | Thanks for the typo fix! |