kingkingHK's Comments
| Changeset | When | Comment |
|---|---|---|
| 174776599 | Nullah Road -> Tung Choi Street needs it? Also, isn't a "road completely useless for through traffic" just `highway=service`? See e.g. nearby way/966100009 |
|
| 178666019 | What's the purpose of `bicycle:pushing=`? Isn't it already implied by `bicycle=no`? (because of pushing is allowed it would be `bicycle=dismount`) |
|
| 178574929 | I might be nitpicking yet again, but I don't think you should move way/935824986 that far downstream. |
|
| 178574052 | Imo you should have un-deleted original relation like changeset/177142376 to "preserve the history" , not create a new one, but this isn't really important so I guess I can let it slide. |
|
| 178483414 | While legally right turn being allowed does imply u-turn allowed, with the prevalence of no u-turn signs in HK, I would assume u-turns are not allowed unless I have reasons to believe otherwise. > The plan is to somehow add e.g. source = mapillary to the turn restriction itself so in the future people will know something is up when they see a source tag. Or maybe, don't remove stuff without doing some trivial research... |
|
| 178483495 | Imo the problem is that these lines are essentially "virtual", so the curves are not verifiable. |
|
| 178483495 | I think the turning path should be straight? changeset/172570161 |
|
| 178483414 | Its seems like it has a no u-turn sign though. https://www.mapillary.com/app/user/xingewen?lat=22.408717158153&lng=113.98122454034&z=17&pKey=828985421364427&focus=photo |
|
| 160399716 | > iirc I have never declared my stance on the mapping style of "free ref node"; this is observed to be seemingly a convention. I never said you had a stance, I only pointed out that your convention observation may or may not be due to the quoted changeset which afaik affected all traffic signals in HK; it wouldn't be surprising if you saw their mistake (not knowing it was a mistake) and called it a convention. I apologise if my wording created some misunderstanding. > To clarify, my comment on that changeset is essentially "that free ref node shouldn't exist because there's no traffic signals at the roundabout". There is no judgement on whether it's good or bad. Imo, a node being 120+ metres away from where it should be is pretty bad. I hope this is not a controversial opinion. > I find merits of that style, because now I can very easily know where a specific ref traffic signal is located. Can't we have `ref=` on the `highway=traffic_signal` on the highway? This is the prevalent practice for tagging `=traffic_signal` `ref=` afaik. > sometimes we just don't know where that box is skill issue tbh > maybe there are multiple boxes for the same set of signals I am not aware that there are traffic signals like that, at least in Hong Kong. How would that even work? Two separate computers controlling the same light? I am only aware that sometimes multiple separate faraway junctions are controlled with the same box, as part of a green wave. > And, specifically, for this case, I did not know / did not notice where the control box is at. Coincidentally I went there today and saw it is at the south-west of the crossing. |
|
| 160399716 | @vectorial8192 perhaps you only thought that because of changeset/73295449 which we have previously found to be poor-quality in note/5004149 ? |
|
| 160399716 | Hi there, is node/12433769176 duplicating node/11684634793 and node/12433769175 ? |
|
| 178323967 | 1. While the "STOP 停" markings do indeed resemble a triangle due to the English text being long and Chinese text being slim, with some more effort you can see it looks more like a text than a triangle. You can also see some thick white lines, which doesn't make sense if it is a give-way double dash line. Look at some give-way road markings (e.g. the roundabout to the west) to see what give way actually looks like. |
|
| 178293153 | Split too early again? changeset/177647860 |
|
| 178089087 | Iirc there are three levels between the APM and the arrivals. I don't remember the exact level relative to the ground, but assuming `level=-2` for the APM is correct, then the gates should be `=3;2`. (Ok I see you fixed it already changeset/178153215) |
|
| 178191616 | I thought we don't do `=bus_station` for on-street termini? Anyway, for future reference: https://hkbus.fandom.com/wiki/%E5%BA%B7%E6%80%A1%E8%8A%B1%E5%9C%92%E7%B8%BD%E7%AB%99 (Also I doubt the "guys from HKBusFandom" will notice this note/changeset, so the minibus stop might never get mapped if we don't do it.) |
|
| 178131849 | Do we really have `surface=fine_gravel` in such an urban area? |
|
| 178137127 | Dupe node/4443950090 ? (and should we even map such things in osm?) |
|
| 178089087 | Re `level=`, aren't there many (non-public, but still used by airport personnel) levels between the ground and the gates, meaning it should be higher than `=2;1`? |
|
| 177963900 | I might be misunderstanding things, but I think semi-detached means sharing exactly one wall with a neighbouring building, and walls separating backyards don't count? |
|
| 177963756 | `building=terrace` is different from `building=house` + `house=terrace`. `building=terrace` is when all of the terraced houses are mapped with a single osm way. `building=house` + `house=terrace` is for terraces where each house is mapped with its own osm way, as in the case here. Not to be confused to `building=house` + `house=semi-detached` which is synonymous with `building=semidetached_house`. |