RE: way/1414980362

Hi Mezzy,

Can you please help me understand what you're trying to do with this golf course? It appears that you are simply tracing existing objects (fairways) and creating duplicate objects. I'm going to revert your changes, but want to check in with you so I can understand and help you achieve what you set out to do, but in a way that is compatible with OSM practices. Thanks!

Hey there CurlingMan13,

Thanks for helping clean up golf courses. FYI, you can't share fairway nodes with the green nodes when you have a fairway before and after a hole like the fourth hole in this changeset. Something about it not being a mathematically simple geometry. Some editors (JOSM in particular) will warn you against that type of edit, but I guess iD doesn't. I've gone ahead and fixed it up here (way/1415176817) for you but wanted you to be aware for future edits where the green doesn't have a clear fringe around it.

Thanks.

Please don't draw cart paths as areas. Thanks.

RE: way/593951832

When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the lines used to outline those areas can't cross over each other. Fairways outlines shouldn't cross over greens or fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. (The same can be said about fairways and bunkers, tees, roughs, etc.) There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. Thanks.

Hey Pascal! Wasn't sure this was you or not. Love your tools!

I agree with everything you say. I'm a "mega active" mapper, mostly due to golf course cleanup over the last few years. I was already cleaning up the edits from the user and noticed your comments. I didn't see any "call to action", so I wasn't sure if it was intended for the mapper of this particular changeset or a trigger for others to look into it. Sounds like it is that latter.

Is there some coordinated effort that chases down these tags? I'd love to know about that if so.

Thanks.

@NeisReview: what is the purpose of your changeset comment? It doesn't provide any value afaict.

There's a few problems with way/638818957.

* You moved the fairway and green to an entirely different spot on the map
* The fairway and green are still intersecting each other since they aren't sharing all nodes on the boundary. Looks trivial, but this still sets of the automated Q/A checks that look for this error.
* The golf=hole is now all out of whack
* The golf=hole shares a node with the green. It shouldn't.

hmm, not sure how that happened. sorry about that.

Thanks for getting back to me 2019.

I agree there is no rough between the fairway and green on the 16th hole and the two should butt up against each other. You said you updated them to not overlap, but the one hole I referenced at the top of my comment is still wrong? Did you miss this one? You have the fairway overlapping the green instead of sharing the boundary nodes: https://ibb.co/SwJ4fpMz

What it needs to look like is this: https://ibb.co/GQSBd3Kx

I hope that makes sense. If not, please let me know. Thanks.

Same issue here. The rough and bunker ways shouldn't intersect each other. The rough needs to go around the bunker.

RE: way/638645840

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

RE: way/1079079461

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Objects that are joining each other should *share* nodes on the border, but not cross over each other. Alternatively, you can go around one of the objects and leave a small gap. For instance a fairway polygon that skirts around a bunker. Please read this wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Zoom all the way in to this node: osm.org/edit?node=12937737794

And you'll see that there is an incursion into the area defined as "rough".

RE: way/1413051513

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Objects that are joining each other should *share* nodes on the border, but not cross over each other. Alternatively, you can go around one of the objects and leave a small gap. For instance a fairway polygon that skirts around a bunker. Please read this wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

RE: way/1412580299

As mentioned in previous changeset comments, your fairways shouldn't be intersecting other golf course features, and you shouldn't be using the lollipop style of mapping (use multipolygons instead). Please see previous changeset comments for links to wiki pages and reach out to me if you need help. Thanks.

RE: way/1412242875

As I explained a couple of months ago in changeset/166523141, you can't intersect golf features like fairways and greens. That is invalid mapping and sets up Q/A tools and needs to be corrected and avoided in the future. Please read the previous comments and reach out if you have any questions. Thanks.

Thanks. Nice to see this will be correct from the start.

RE: way/1411687104

The lines that define fairways, roughs, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Objects that are joining each other should *share* nodes on the border, but not cross over each other. Alternatively, you can go around one of the objects and leave a small gap. For instance a fairway polygon that skirts around a bunker. Please read this wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

RE: way/765243777

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Objects that are joining each other should *share* nodes on the border, but not cross over each other. Alternatively, you can go around one of the objects and leave a small gap. For instance a fairway polygon that skirts around a bunker. Please read this wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls.

As the designation of "rough" is arbitrarily decided for the area around the tee box, you might consider joining the two large rough areas into a single rough. Alternatively, you could just leave the rough off the map since anything outside of the fairway kind of defaults to be "rough" if that makes sense.

If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Hi Yamski,

As I mentioned in a comment on a previous changeset by you (changeset/168241298), you shouldn't have your fairways and greens intersecting. Please make sure this gets fixed and doesn't continue to happen. The link above should contain helpful information about how to map golf courses. Please check it out. Thanks.