b-jazz's Comments
| Changeset | When | Comment |
|---|---|---|
| 168321626 | RE: way/894465889 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Objects that are joining each other should *share* nodes on the border, but not cross over each other. Alternatively, you can go around one of the objects and leave a small gap. For instance a fairway polygon that skirts around a bunker. Please read this wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
|
| 168323549 | RE: way/1410979347 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Objects that are joining each other should *share* nodes on the border, but not cross over each other. Alternatively, you can go around one of the objects and leave a small gap. For instance a fairway polygon that skirts around a bunker. Please read this wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
|
| 168280755 | RE: way/1410714766 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
|
| 168229975 | 99.9% of golf courses aren't lit. Please don't litter this tag on any more golf courses. Thanks. |
|
| 168244129 | RE: way/818555966 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
|
| 168241298 | RE: way/1410423910 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
|
| 168155115 | RE: way/1409848406 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. Object that are joining each other should *share* nodes on the border, but not cross over each other. Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
|
| 168117933 | RE: way/1409641303 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
|
| 168093618 | RE: way/915665162 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
|
| 167980030 | RE: way/699305664 FYI, if you can't leave a gap the entire way around the green, you should exclude the green and share all the boundary nodes on the "inside" of the green if that makes sense. I've gone ahead and fixed it up so you could see how it should be done. Thanks. |
|
| 167979936 | RE: way/699280007 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
|
| 167885637 | Hi again tomyak, I saw that you created a multipolygon on the 18th fairway, but it only contained a single object (the outer ring of the fairway). Technically, this is incorrect, as it's a single polygon and doesn't need to be made a multipolygon unless it has some inner feature that's different (like a bunker commonly). I'll go ahead and fix it while I'm here but thought you'd want to know about it so you can avoid that pattern. Thanks. |
|
| 167925417 | RE: way/1207321367 The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
|
| 167931805 | Hey BB, Thanks for contributing to the map. Please be aware that you need to attach the fairway to the green in situations like this hole. That means that you need to *share* every node at the boundary of the two objects. Thanks! Have fun mapping and golfing. |
|
| 167888916 | I cleaned up the 12th hole in case you want an example of how it should look. Feel free to reach out if you need help in recreating what I've done elsewhere. |
|
| 167879584 | RE: way/1405169650 I've pointed out in several previous comments on your changes that you need to stop intersecting your golf course features. In the case above, between a bunker and a rough. You're also doing "lollipop" mapping, which is problematic and should be avoided in favor of proper multipolygons. See the wiki pages (mentioned in previous comments) on how to handle those situations. Thanks. |
|
| 167849779 | Hello again Tom, You also don't want to do this thing where you break down a feature into parts like you do with way/1396718878. You'll want to draw the rough as a single polygon and the two bunkers inside and then combine them by selecting all objects and right clicking one of them and selecting "Merge" (I think that's what iD calls it). This will create a proper "multipolygon" with the inner/outer features labelled correctly. Let me know if you have any question and I'll gladly help clarify things. thanks. |
|
| 167806865 | RE: way/1396492886 First, can you explain why you split the fairway in half like that? You shouldn't be doing this and I've seen a handful of people do this and I'm trying to make sure it never happens again. I'd really like to understand why first. Second, you shouldn't have your features overlapping like the fairways and the bunkers do in the example above. If you are excluding something like the bunker, you can butt them up against each other and share the boundary nodes, or you can leave a gap between the two, but you do not want to be just crossing them over like you've done. Please correct these. Thanks. |
|
| 167829746 | RE: way/1396598176 As mentioned in previous comments on your changesets, golf course elements like bunkers and fairways shouldn't intersect each other. They can share boundary nodes sometimes, but they can't overlap like you've done in the bunker above. Please correct this error and do your best to avoid repeating it in the future. thanks. |
|
| 167773311 | Hello Noah, I've removed the mess of triangles around the golf course. I don't know what you were trying to accomplish, but many adjoining triangles is not the answer. Also, a body of water that far from a golf hole is not normally considered a water hazard as the likelihood of a ball going in the water is very low. |