FYI, the correct tag when numbering holes (fairways, greens, etc) is "ref", not "hole". I've fixed up this batch but thought you should know for future edits.

You're probably referring to an earlier change in the history than my change. You might want to view the object in question's history and find someone else. I only touch the "website" tag. I have no hand in touching the "shop" tag.

Oops, reused wrong changeset description. This was a revert on a bad change that violated basic golf course etiquette (fairways crossing over greens)

RE: way/1445319095

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green along with the right way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

Thanks for creating these greens, but please make sure your greens don't intersect with other existing (or created) golf areas like fairways. If you need to fix someone else's work, please do so that it doesn't create an inconsistency (error) in the map. Thanks.

Hey there ICT,

Just wanted to let you know that golf holes have a direction to them and go from the tee to the green. I've gone ahead and fixed them on this course but wanted you to know for future mapping. Thanks.

Hi Jaker, I just wanted to let you know I made a couple of small changes to your golf course mapping. The start of the golf=hole line you drew in a couple of places was labelled as a golf=tee. But the area around that was already marked as a tee, which is redundant. So I removed the tag on the node itself. Just thought you'd want to know.

RE: way/1443109313

There are a couple problems with this "rough" area. The first is that it crosses over cart paths. It should be kept to the grass, so should be split into two whenever a path intersects the rough. The second problem is that it intersects with a bunker. Areas like fairways, roughs, greens, bunkers, tees, etc should never intersect each other.

If you could go back in and fix this, I would appreciate it. Thanks.

You're the best! Thanks.

Hey wadenick, looks like you are doing a lot of great work. However, I did come across this one bunker (way/1435238413) that seems to have been ignored as you were drawing the fairway and crossed over it. Seeing how all of the other bunkers here are correct, I'm guessing this was just a mistake.

Thanks for getting back to me Chris. Much appreciated. You are correct in saying that putting fairway/green pairs into a multipolygon relation "isn't mandatory". However, taking an existing pair that is in a relation and breaking that relation is frowned upon.

As for getting the author to make a change, that would be fantastic. If you are talking about "Chad's Tool", there already exists a fix that just hasn't been incorporated yet. It's been out there for at least 6 months. Any pressure you can put on the author would be appreciated. If you are technical, I'm guessing you could incorporate that fix in your own fork of the tool and have a private working version. If that is the tool you're talking about and you need more info, let me know.

Hey Chris. What you've done here with "removing inner/outer definitions" is incorrect. A fairway that surrounds a green is defined with a multipolygon with the fairway as the outer and a green as the inner. Please stop making changes to relations unless you fully understand how they are used. Thanks.

Holes shouldn't have "names" typically. There are rare exceptions, but the hole is not named "1". It has a reference number of "1" and that's how you know which hole it is. Please don't add names in the future. Thanks.

You need to work with the author of your tool to implement a fix on their side. OSM has strict, well documented, standards on how to map everything from roads to golf courses to zoos. This isn't an OSM problem, it's a golf simulator problem.

This is a long standing bug that they are aware of. There is even a fix that has been proposed that hasn't been integrated yet. See https://github.com/chadrockey/TGC-Designer-Tools/pull/143. Maybe you could add your voice to the pull request asking it to be incorporated. If you're technical enough, you could pull it yourself into a private version of the tool and run your own fixed version.

Breaking golf courses in OSM and causing others to have to clean up after you will likely result in a ban. And honestly, none of us want to see that happen. Thanks.

RE: way/1441878752

Please don't use the "lollipop" style of mapping golf course elements as you've done in the URL above. You need to create proper multipolygon relations in order to map features like roughs/bunkers that are within other features like fairways. Please see leisure=golf_course#Common_mapping_pitfalls and osm.wiki/Relation:multipolygon for help in understanding how to map this situation. If those aren't clear, please let me know and I'll help explain them further. Thanks.

They will be. It takes time to correct years of bad practices. The vast majority of them have already been fixed.

This edit is incorrect and breaks the existing relation.

Please see the wiki that explains this: osm.wiki/ID_understanding_golf_course_relations

thanks

I tried to revert my change, but since you've made additional edits to the area, that creates conflicts that are nearly impossible to resolve. Sorry.

While you're in there, please don't have separate fairways for the main fairway and for the fringe around the green. They really should be a single fairway. Even if there are subtle difference in how the grass is cut. Thanks.

Reverted this and several other changes on this course over the last 24 hours that violate rule #1 of golf course mapping: golf course areas (fairways, greens, roughs, tees, etc) should not intersect each other. The previous versions of these holes were correct. If you need to adjust geometries, please make sure you read the golf_course wiki and follow the rules as laid out there. Thanks.

You made some changes to the green at way/685037079. It used to be a multipolygon with a fringe defined by the outer way/fringe and the green. But somehow the fairway was deleted and the relation between the two is "broken". Not sure what the purpose of the change was. Sometimes you see people deleting a feature entirely and then re-adding it from scratch and wind up with this situation, but that doesn't appear to be the case here.

I'm starting to write a wiki article about how to handle multipolygon relations and golf course mapping, but it doesn't directly match this case, but maybe you'll find it useful how to deal with relations in iD (which can be confusing).

osm.wiki/ID_understanding_golf_course_relations