pwbriggs's Comments
| Changeset | When | Comment |
|---|---|---|
| 168618349 | Thanks for the contribution. A more appropriate & machine-readable way of tagging this might be with a [lifecycle prefix] on the building. You can read up about these lifecycle tags on the wiki page I linked, but it sounds like `destroyed:building` would work here if the building still remains, otherwise `demolished:building` if it's been demolished since the fire but still shows up in aerial imagery. Thanks again, and welcome to OpenStreetMap! [lifecycle prefix]: osm.wiki/Lifecycle_prefix |
|
| 168285706 | ...because I figure it makes more "semantic" sense this way. |
|
| 168214336 | Thanks for the contribution. Is this a new/renovated building? I don't see any construction in 2023 aerial imagery, and I'm not sure why such a building would be renovated to be smaller. Could you please provide additional information here? Thanks. One other minor thing to note is that if you specify the address on the building itself, you can remove the address point/node, because otherwise the point becomes redundant. (A helpful trick to make this easier: in the default iD editor, you can shift-select a building and its corresponding address point, then hit C (or right-click > "merge") to automatically copy the address to the building.) Thanks again for contributing, and welcome to OpenStreetMap! Please leave a message here if you have any questions! |
|
| 168040352 | Thank you, sorry for maybe overreacting! 😀 Happy mapping! |
|
| 168056631 | @Great Carmania Silver City, thanks for the contribution and welcome to OpenStreetMap. To add your business, you should create a separate "point" (node) at the business location, and then add your business info to that node. Feel free to add a comment here if you have any questions. |
|
| 168040352 | Hello user_5359, Could you explain why you merged these locations? You seem to have appended a lot of information with semicolons, are these the same business? Please cite your source using the source tag, and use a descriptive changeset comment. Thanks! |
|
| 167860608 | Thanks for the contribution and welcome to OpenStreetMap. I saw that this is your first edit and had a couple things to note. First, is this the correct location? I see two industrial buildings closer to the road than you marked, are these the elevator company? It's difficult to tell because of the tree cover, but I don't see any buildings in the location you marked. Second, note that the `image` tag is meant for a photo of the building or feature itself, not the logo of the business. As such I removed the image tag. Finally, I updated the phone number you added to use the phone number format specified in the official wiki: phone=*#Usage OpenStreetMap definitely has a bit of a learning curve to it, but I'm glad you're making contributions. Thanks again and happy mapping! |
|
| 167868000 | Hello and welcome to OpenStreetMap! I was reviewing your changeset and I noticed that you only wrote "-" in the changeset comment field. In the future, please do use meaningful changeset comments-- as “-” does not help other mappers understand what you are doing. Please see osm.wiki/Good_changeset_comments for more information. I also noticed a few minor issues with the format of the information you added, for example the opening hours have a specific machine readable format they're required to be in. I fixed these for you; you can see my changes at changeset/167895725. Thanks again for the contribution! |
|
| 167863484 |
Hello and welcome to OpenStreetMap! I was reviewing your changeset and I noticed that you only wrote "-" in the changeset comment field. In the future, please do use meaningful changeset comments-- as “-” does not help other mappers understand what you are doing. Please see osm.wiki/Good_changeset_comments for more information. Thanks again for the contribution! |
|
| 167777742 | Thank you for the contribution. I noticed a couple things while reviewing your first changeset. First, it looks like you accidentally removed the highway tag from a segment of E Portland Ave. This was causing data consumers to not know this was a road. I added the `highway=secondary` tag back for you. Second, the street name in the address you added didn't quite match the name the street is tagged with (East Portland Avenue). It's important to spell out the full street name (including abbreviations) so that computers can understand street names. I also fixed this for you. But these are both easy mistakes to make as a beginner. OpenStreetMap has a kind of learning curve to it. Thanks again and welcome! |
|
| 167439020 | Okay, thanks for the info. They both link to the same Facebook, so I was wondering if these two associated shops are different. |
|
| 167761743 | Thank you for the contribution! In addition to a name, POIs should also have tags that describe what they represent. For example, a restaurant would have its name tagged, but also a tag indicating that it is a restaurant-- otherwise data consumers don't know how to interpret that place. I also noticed that you're using JOSM as your editor. JOSM is a really great advanced editor, but as a beginner I would recommend trying out iD--which can be opened using the dropdown next to the edit button on openstreetmap.org. iD tries to simplify mapping by, for example, using preset tag lists that let you choose something like "restaurant" and automatically adding the correct tags. If you have more questions, feel free to ask here, or there are some really great beginners' guides available, like osm.wiki/Beginners%27_guide. Thanks again for your contribution, and welcome to OpenStreetMap! |
|
| 167384941 | Hello and welcome to OpenStreetMap! I was reviewing your changeset and I noticed that you only wrote "-" in the changeset comment field. In the future, please do use meaningful changeset comments-- as “-” does not help other mappers understand what you are doing. Please see osm.wiki/Good_changeset_comments for more information. Thanks again for the contribution! |
|
| 167439020 | Welcome to OpenStreetMap! Is this a separate storefront than "side pro exteriors"? |
|
| 167591355 | For discussion please see note/4804871. |
|
| 167110576 | Okay, thanks for the info. Sounds like the tagging is good for now, then. |
|
| 167110576 | Thanks for the contribution. I noticed you left the `admin_level=6` tag here. `admin_level` is used to indicate what level of government an object is associated with (in this case level 6-- King County). I removed admin_level. Do you know what's located here now? Is it a new office, or just a vacant storefront? Thanks again, and welcome to OpenStreetMap! |
|
| 166950425 | Sounds good, thanks! And don't worry too much about preserving the old object if you accidentally delete it-- it's not that big a deal. Happy mapping! |
|
| 166950425 | Okay, thanks for confirming. Looks like you're good to continue mapping these buildings @HackBug! Thanks! |
|
| 166950425 | Thanks for the contribution! Your usage of `house=terraced` looks good to me. One thing I would note is that we generally try to "preserve the history" of objects by *changing* them rather than deleting & creating new objects. In this example, you've deleted the original `building=apartments`. However, since the new `house=terraced` units refer to the same physical object that the original single building referred to, it might make more sense semantically to adjust the shape and tagging of the original building into one of the individual houses (and then create additional townhouse areas for the other houses in the row). See osm.wiki/Keep_the_history for more info. I did also notice that you have both `addr:housenumber` and `addr:unit` on each house. This is probably correct, but I'm not sure (I've never used `addr:unit` myself before). I've asked OSM US for a review (https://slack.openstreetmap.us/ #tagging) Thanks again for the contributions and welcome (back?) to OpenStreetMap! |