Hello and welcome to OpenStreetMap!

I was reviewing your changeset and I noticed that you only wrote "-" in the changeset comment field. In the future, please do use meaningful changeset comments-- as “-” does not help other mappers understand what you are doing.

Please see osm.wiki/Good_changeset_comments for more information.

Thanks again for the contribution!

Thank you for the contribution. I noticed a couple things while reviewing your first changeset.

First, it looks like you accidentally removed the highway tag from a segment of E Portland Ave. This was causing data consumers to not know this was a road. I added the `highway=secondary` tag back for you.

Second, the street name in the address you added didn't quite match the name the street is tagged with (East Portland Avenue). It's important to spell out the full street name (including abbreviations) so that computers can understand street names. I also fixed this for you.

But these are both easy mistakes to make as a beginner. OpenStreetMap has a kind of learning curve to it.

Thanks again and welcome!

Okay, thanks for the info. They both link to the same Facebook, so I was wondering if these two associated shops are different.

Thank you for the contribution!

In addition to a name, POIs should also have tags that describe what they represent. For example, a restaurant would have its name tagged, but also a tag indicating that it is a restaurant-- otherwise data consumers don't know how to interpret that place.

I also noticed that you're using JOSM as your editor. JOSM is a really great advanced editor, but as a beginner I would recommend trying out iD--which can be opened using the dropdown next to the edit button on openstreetmap.org. iD tries to simplify mapping by, for example, using preset tag lists that let you choose something like "restaurant" and automatically adding the correct tags.

If you have more questions, feel free to ask here, or there are some really great beginners' guides available, like osm.wiki/Beginners%27_guide.

Thanks again for your contribution, and welcome to OpenStreetMap!

Hello and welcome to OpenStreetMap!

I was reviewing your changeset and I noticed that you only wrote "-" in the changeset comment field. In the future, please do use meaningful changeset comments-- as “-” does not help other mappers understand what you are doing.

Please see osm.wiki/Good_changeset_comments for more information.

Thanks again for the contribution!

Welcome to OpenStreetMap! Is this a separate storefront than "side pro exteriors"?

For discussion please see note/4804871.

Okay, thanks for the info. Sounds like the tagging is good for now, then.

Thanks for the contribution. I noticed you left the `admin_level=6` tag here. `admin_level` is used to indicate what level of government an object is associated with (in this case level 6-- King County). I removed admin_level.

Do you know what's located here now? Is it a new office, or just a vacant storefront?

Thanks again, and welcome to OpenStreetMap!

Sounds good, thanks! And don't worry too much about preserving the old object if you accidentally delete it-- it's not that big a deal.

Happy mapping!

Okay, thanks for confirming. Looks like you're good to continue mapping these buildings @HackBug! Thanks!

Thanks for the contribution!

Your usage of `house=terraced` looks good to me.

One thing I would note is that we generally try to "preserve the history" of objects by *changing* them rather than deleting & creating new objects. In this example, you've deleted the original `building=apartments`. However, since the new `house=terraced` units refer to the same physical object that the original single building referred to, it might make more sense semantically to adjust the shape and tagging of the original building into one of the individual houses (and then create additional townhouse areas for the other houses in the row). See osm.wiki/Keep_the_history for more info.

I did also notice that you have both `addr:housenumber` and `addr:unit` on each house. This is probably correct, but I'm not sure (I've never used `addr:unit` myself before). I've asked OSM US for a review (https://slack.openstreetmap.us/ #tagging)

Thanks again for the contributions and welcome (back?) to OpenStreetMap!

Thanks for the contribution. The website tag should specify a complete URL (including `https://`), and point to a page specific to this business location, if a business website has multiple locations. (The OpenStreetMap wiki is a really useful resource that documents how to use keys correctly-- see website=* for the page about this tag)

I changed `thirdplacebooks.com` to `https://www.thirdplacebooks.com/seward-park`

But anyways, thanks for the contribution. Welcome to OpenStreetMap!

Also: address added based on https://gismaps.kingcounty.gov/iMap/.

Confirmed based on Bing Streetside imagery. Thanks for the contribution and welcome to OpenStreetMap!

Me too 🙂 but I wasn't sure about the comment syntax because I've never really seen it in the wild. Thanks again.

I flagged for review because I wasn't quite sure the `opening_hours=` was correct here— thanks for confirming!

Thanks for the contribution. Can you update this to use the phone number format in the official wiki: phone=*#Usage? Thanks again, and welcome to OpenStreetMap!

OpenStreetMap is a live database. Feel free to experiment with modifying the map in the editor, but please be careful not to upload your experimental (and incorrect) changes to the live map. Thanks! (see also: osm.wiki/Sandbox_for_editing#Experiment_with_editing_the_map)

changeset/165875352

Thanks for the contribution and welcome to OpenStreetMap!

I noticed that you mapped this as 3 separate buildings. If these are all the same building on-site, it might make more sense to just add separate address points instead (unless the building is clearly divided with separate businesses or such in the 3 different sections, and possibly interior walls dividing them). Let me know what you think about this.

I also noticed that you connected the new buildings to the tire center in the adjacent lot. I've disconnected it and cleaned up the industrial/commercial zones as well.

Finally, a helpful feature in iD (the default OSM editor) is the "square" function. You can select one or more areas and click "right-click > square" (or just press "q" on your keyboard). This will try to make 90-degree angles, which is helpful for squaring up building outlines. I've also done this with the separately-mapped buildings you added.

But thanks again for the contribution. OpenStreetMap has a steep learning curve at first! 😅

~PB