jcarlson's Comments
| Changeset | When | Comment |
|---|---|---|
| 120008078 | Oh yeah! Mapping electric utilities can get super intense and detailed. I only know a bit about it myself, but take a look at power=* for examples of all kinds of stuff.
|
|
| 120008078 | Looks great! If you can tell from the imagery, it's a good idea to add some kind of tag to the nodes, too, to indicate what kind of utility pole / structure they are. |
|
| 118450005 | No worries! It wasn't too difficult to fix. |
|
| 118480659 | Done! From recent imagery I'd call a few of them medium, but the rest sparse. |
|
| 118480659 | D'oh! You're absolutely right, it should have been. The correct tag slipped my mind at the time. I have fixed these. Thanks! |
|
| 118450005 | Thanks for adding the different wings of the school. However, adding a feature with "area=yes" on it is generally not very useful unless it includes other tags. In this case, you could split the school feature and add these wing designations as a ref tag, or else add building_part features inside of the main building feature. |
|
| 115781508 | This is a residential area, and is seems very doubtful that JNS Glass is actually operating here. Can you please elaborate on why you think this feature should be here? |
|
| 114569286 | US 30 and 34 had a bunch of issues. 30 is fixed now, though, and I'll probably work through 34 today.
|
|
| 114569286 | It's possible they were broken before you got to them, too, I didn't do a deep dive on the history. It just seemed similar to something I did in the past. |
|
| 114569286 | Nice to see all the lane attributes getting added, but are you by chance loading the features w/ an Overpass query? I ask because a bunch of route relations whose member ways you edited got broken, and I have done that very same thing with lane tagging and sparse editing in JOSM.
|
|
| 115360162 | What was the conflation process, exactly? Oswego, IL, for example, has 4 existing fire stations, all of them in OSM already, and none in the location imported by this changeset. Aurora, IL also had a duplicated station node, and that's just things within a few miles of me. I have to assume with a 2-changeset country-spanning import like this, there are going to be a lot of similar situations. |
|
| 114986710 | I get that, and sometimes that's the case. In my opinion, the business is not the building, it just happens to be using the building. Handling business entities as areas introduces a lot of complexity and arbitrariness.
|
|
| 114986710 | Hello, fellow mapper! Thanks for doing some much-needed cleaning in the area. Is there a particular reason to merge business POIs into the footprint geometry? |
|
| 112813498 | Looks great! Thanks for adding this kind of local knowledge to the map!
|
|
| 112181435 | Hey! Nice to see someone editing around my old school. Do they still have the plaques up for the tree dedications? You could totally add that information. |
|
| 111864808 | What is the purpose of moving these buildings? The features were added with known imagery offsets for this area; moving them slightly to the NW actually makes them less accurate. |
|
| 111823509 | Oh, I do like that sub-area style. I think combined with an appropriate `indoor` tag could lead that to being very high-quality data, while still being accurate with respect to the building itself.
For multi-building situations, it's kind of a toss-up for me. A building MP still implies the business == the buildings. I know that in the case of hotels, it's acceptable to tag the hotel's "campus" with the tourism tag. And really, there's no rule that a `shop` or `amenity` feature must correspond strictly to a building. I'd be curious to see how users would react to the idea of a business way that covers the business' area rather than simply the building. But that's not a discussion for a changeset comment. I'll ping you on Discord and see what other users think about that. Based on the raw numbers in Taginfo, only about 20% of all shop and restaurant features are combined with a `building` tag. In other areas I've edited, I tended to see more businesses as POIs than closed ways, which led me to think (perhaps mistakenly) that there was a "more common" approach. When you filter those features for ways only, though, nearly all (>90%) are combined with a building tag. And that's just globally, so it doesn't catch any regional differences. Personally, I will probably still default to POIs unless I have the local knowledge to know that a building has no other use, or for strip malls, know where the internal dividing walls are roughly located. But I'll stick to either local knowledge edits or adding what's missing from here on out, so that I'm not just keeping other users like yourself busy. Thanks for the feedback! |
|
| 111823509 | Sorry, I just remembered an additional point: some single businesses encompass multiple buildings, too. Tagging only one of the buildings w/ the business information can't capture that either. Not that a POI would, but it at least wouldn't imply a single building as being "the" business. |
|
| 111824484 | D'oh! Bonehead mistake on my part! Sorry about that, that was just sloppy. |
|
| 111823509 | Hi there!
I suppose I've gone on long enough. You're free to disagree with any and all of the above. I was just "cruising" up Rt 34 and kept going out of Kendall County and did some mapping there. But I will always defer to what local mappers prefer in their area, so I will not be offended if you choose to revert this changeset (or any of the similar ones in the area). |