OpenStreetMap logo OpenStreetMap

Changeset When Comment
168734627

Hi, you have changed this pedestrian crossing traffic light to be regular traffic light (traffic_signals=*) while i couldn't reliably verify which type of signals those are, i'd like to point out that you have also reversed the direction signals are facing to (traffic_signals:direction=*). I assume this is purely accidental change as everydoor doesn't have any indicator to help guess, which way the underlying way is drawn.

PS. Since i don't remember traffic lights being here, does this crossing really have signals now?

149331125

Tere, ega sa ei mäleta, kas node/11772485033 on tõesti fooridega ülekäik? Ma pole sealtkaudu ammu liikunud, aga enda teada ma ei mäleta et seal nagu foorid oleks. Küsin sellepärast, kuna üks kasutaja tegi kahtlase muudatuse, et foor paikneb peale ülekäifurada.

168733197

Hi, welcome to OpenStreetMap. Are you absolutely sure this building's walls are made of metal, because that's what building:material=metal means. You may have wanted to add roof:material=metal, which means roof is made of metal.
Also, if you are making changes within single contained area, then it's recommended to put multiple changes into single changeset - meaning you don't have to press yellow arrow every time it appears, only when you have finished editing or feel so. Everydoor will offer you to download data when it deems it necessary.
PS. Seems like you are conducting an organized edit, make sure to disclose that fact on your profile page.

167972832

Hi, Please make sure you provide explanation to changesets. This one is spanning 3 countries due to tiny change in way/648202691, while majority of changes seem to be adding buildings near Peterburg.

167777512

Difference from yesterday's changeset/167754914 is that this time i included nodes that were not part of any crossing-way. Overpass query:

[out:json][timeout:25];
{{geocodeArea:Helsinki}}->.searchArea;
// Step 1: Get all kerb nodes with only one tag
node[kerb][kerb!=no](if:count_tags()==1)(area.searchArea)->.kerbs;
// Step 2: Get motorvehicle roads and their nodes
way[highway][highway!~"footway|cycleway|path"](area.searchArea);
node(w)->.road_nodes;

// Step 3: Remove kerbs that are part of those roads
(.kerbs; - .road_nodes;)->.nonroad_kerbs;

// Step 6: Intersect with nonroad_kerbs
node.nonroad_kerbs->._;
out geom meta;

167754914

For future reference, here’s the Overpass QL I used to select those kerb=* nodes. First, it limits to nodes tagged only with kerb=* (so we don’t touch kerb tags used alongside bus stops or platforms) - this follows the advice in wiki (kerb=*#By_itself). Then, since tagging a node as barrier=kerb implies it’s an obstacle along a way, we explicitly exclude any kerb nodes that lie on motor-vehicle roads (i.e. all highway=* except footway, cycleway, path), because according to wiki standalone kerb=* may have denoted informal crossing.

[out:json][timeout:25];
{{geocodeArea:Helsinki}}->.searchArea;
// Step 1: Get all kerb nodes with only one tag
node[kerb](if:count_tags()==1)(area.searchArea)->.kerbs;
// Step 2: Get motorvehicle roads and their nodes
way[highway][highway!~"footway|cycleway|path"](area.searchArea);
node(w)->.road_nodes;
// Step 3: Remove kerbs that are part of those roads
(.kerbs; - .road_nodes;)->.nonroad_kerbs;
// Step 4: Get crossing ways
way[footway=crossing](area.searchArea)->.foot_crossings;
way[cycleway=crossing](area.searchArea)->.cycle_crossings;
(.foot_crossings; .cycle_crossings;)->.crossing_ways;
// Step 5: Get nodes used in crossing ways
node(w.crossing_ways)->.crossing_nodes;
// Step 6: Intersect with nonroad_kerbs
node.nonroad_kerbs.crossing_nodes->._;
out geom meta;

126353773

Pretty sure there was bicycle parking at one entrance, but not at another. Bit further away from entrance than cart storage.
Looking at mapillary it seems like I've misplaced the node as it should be closer to NE corner on handicapped parking. https://www.mapillary.com/app/?lat=59.419488608892&lng=24.762347247475&z=17&pKey=295881068672651&focus=photo&x=0.17658996465528115&y=0.5474598750641052&zoom=2.1171493936689756&menu=false

85905341

Hi,
They seem to be selling products made of thin film of plastic (called "kile" in estonian). Judging by product selection on website, it's specialized on construction materials (such as steam barriers), gardening supplies (garden bed covers and greenhouse material) and various packaging and wrapping products (different kinds of plastic bags). They do offer some textile products as well (for gardening and construction).
Feel free to change it to more appropriate tag. I'm afraid that DIY shop might not be appropriate as these kind of products are more oriented towards professional construction/maintenance segment, not hobbyists.

127744153

For future reference, linking the block message because it contains links to some of Aulo's (user id 417306) changesets and their discussions:
osm.org/user_blocks/6403

127744153

Thanks. I wanted to report Aulo's actions to talk-ee month ago, but got overloaded by non-OSM-related stuff.
Could you also please take a look at crossings? Because at some point i noticed how Aulo had converted a lot of crossing=traffic_signals into marked crossings. If you are busy, removing the crossing types would be sufficient, i can reclassify them in SC.

126138420

P.P.S @waterproof_19m, ma ei olegi varem EHRist geomeetria importimisele mõelnud, paistab, et nad kasutavad hoone kujude jaoks teistsugust allikat kui Maa-amet. (või on ministeeriumite ühishoone geomeetria registris lihtsalt vigane)

126138420

Warning: very long message. You can just copy this message to Word to make reading it more bearable.

Tere,

First off, let's start with a brief overview of history. When i became OSM mapper, there was an active building import by SviMik that was focusing on adding new buildings from Maa-amet (MA from now on). SviMik had a policy, that to avoid possible editing conflict (conflict as overwriting someone's work without their consent), his bot would only either add new buildings or update addresses on buildings last edited by selected users/bots (mostly large volume users such as Verbatium, xybot and juhanjuku). At same time buildings added by his MA imports had very high data quality. Because of trying to not interfere with possible future imports, I'm still not really proficient at mapping buildings.

Collection of some resources regarding to SviMik's import.
SviMik's OSM website that was used to validate the data before bot imported it - http://osm.svimik.com/?lang=en
Import notice/documentation on wiki - osm.wiki/Maa-amet#Import
Talk-ee mailing list on Svimik import - https://groups.google.com/g/openstreetmap-ee/c/HnD85p3Wg9s (there are few other threads related to imports there, but it's not worth linking them here)
SviMik_import - @SviMik_import

Importing new buildings as outlines is not really difficult per se, just download ETAK data shapefile from MA and upload them with Josm. Problem here is the OSM's expectations for quality. For example, the most obvious step is adding tags that are suitable for OSM object and not uploading buildings that are already added to OSM. However, there are more nuances which reveal themselves after you have decided to start this process. In Estonian context, MA's geometry data is sometimes too high quality for modern OSM expectations (e.g having 40+ nodes per circular way while OSM standard is 20) or has minor artefacts caused by technical limitations of their internal software (complex issue, but it results in too many nodes on a straight line).

Those were just issues i had with geometry import. Another dimension is getting the address data right. My import focused only on geometry, because tags were already updated by SviMik's import in 2019. However, i noticed that address field in the dataset was just single text field - it would be really difficult to try to generate address tags from this field. More reliable source might be MA's ADS (aadressiandmed), but since that's not downloadable, just an API, then i believe using it would quickly become bottleneck for the import process. SviMik's source code for import bots is not public, mine is indeed on github repo linked above.
In future I personally would like to also incorporate data from Ehitisregister (EHR), because from there we could get data for building level, building materials, age etc for hundreds of thousands of buildings, but sadly that's unresearched topic, meaning OSM community might not have knowledge on how to obtain and process EHR’s data or if it’s even legal (by having compatible license). MA and EHR aren't directly linked either, so it would require lot of additional work to get buildings in two datasets to match each other.

My import on wiki - osm.wiki/Maa-amet_building_geometry_update
ETAK dataset on MA server - https://geoportaal.maaamet.ee/est/Ruumiandmed/Eesti-topograafia-andmekogu/Laadi-ETAK-andmed-alla-p609.html
EHR example data https://livekluster.ehr.ee/ui/ehr/v1/building/120772119

Replying to qqqqqqqqqqqqqqqqqqqq's questions:
0.1) There are various wiki pages regarding to imports and their documentation. Almost all known imports are documented on osm.wiki/Import/Catalogue I think all known large-scale organised Estonian imports are featured on that table, just use ctrl+F to find them. If either of you is going to conduct an import, please start from osm.wiki/Import/Guidelines and AECoC for generic guidelines on topic.
0.2) MA-geom import's main principe was to refrain from touching nodes that hadn't been updated for at least decade. My initial plan back in 2021 was to run second phase of import in spring 2024 (to update SviMik's first import) and then third run around 2028..2030. I have no idea if SviMik has any plans with his import.
1) Yes, that's the script. Can't give any guarantees if it's going to work.
2.0) Regarding other importable building properties, refer to paragraph on EHR.
2.1) Road refs are relatively easy thing to import. You need to keep in mind two main caveats:
2.1.1) Roads on ground (and in OSM) usually follow logical path while road registry (and therefore ref-numbering) follow parcel and local gov boundaries, meaning that you will need to pay extra attention to matching lot of parallel and/or intersecting roads and splitting OSM ways accordingly.
2.1.2) OSM has route relations, so you'd need to put in extra effort to your import script to make sure you don't break them while splitting ways.
2.1) (continued) Past summer I was travelling between Tallinn-Pärnu and discovered there were discrepancies not just on-the-ground and in road registry, but even same road's different ends had different names. Best known example could be Pärnu maantee, which is called that way in Tallinn, Tallinna maantee in Pärnu, but Tallinn-Pärnu-Ikla road in official registry. Sample changeset/region: changeset/123379963 (this one was done by hand.)
2.2) As for finding other potentially interesting things to add, take a look at different applications and map layers offered by MA: https://geoportaal.maaamet.ee/est/Kaardirakendused-p2.html
Back in 2010 there was navigation aids' import. That might have some interesting value, but problem is that due to legal reasons MA is not really keen to distribute machine-readable data about them. Sea charts have information about shipwrecks, this information can be connected with Vrakiregister to add shipwrecks to OSM.

P.S I was told this comment should be a wiki page. Problem is that I'm replying to your discussion too directly, so converting it to wiki page will require lot of editing.

82460204

Once upon a time i was taught that cyclist can't ride on the street if there is designated cycleway next to it. Double checked traffic laws and streetlevel imagery - Yes, those restrictions can be removed.

117835146

PPS. You have previously mentioned you don't write neither reasonable changeset comments nor split changesets into smaller regions because you don't have time. However, this changeset is part of series of 17 changesets made in 2 hours. I think making two changesets, one for eastern and other for western hemisphere and including adequate changeset comments could have actually been faster than your current process.

117835146

I'd also like to point out language use of this changeset comment. This appears to be global changeset made by russian-speaking user (see created_by value) making changes mostly in Russia (see modified objects list), yet comment on this chset is in German.

Dear iWowik, what is this changeset's connection to Germany? Why is changeset comment in German, not English or Russian?

PS. According to https://resultmaps.neis-one.org/osm-discussion-comments?user=iWowik , the user has been notified and confirmed receiving the information about large changesets and changesets comments since April 2021.

117768233

Tere, Priit.
iD kaardiredaktoris vaikimisi kuvatav Bingi pildikiht, mida sa kasutasid, on kõige halvem valik, mis on Eestis saadaval. Kõige paremad on Esri ja Maa-ameti (Estonia Ortho, Estonia Cadastre) kihid. Kaardikihi vahetamise aken avaneb parempoolsest külgpaneelist või klaviatuuri otseteena klahvi "B" abil.
Üldpildis ei tekkinudki kuigi suuri vigu, välja arvatud jalgtee Tööstuse tänaval (way/556539564) ning Vihuri tn kurv (osm.org/edit?background=maaamet.ee-orto&way=438948859).

116138570

@SimonPoole That's pretty much default behaviour in Josm - if you use click-and-drag method for selection tool, then it will select all nodes and ways within area by default.
@Pan, after selecting them such way, you can press ctrl+F, insert `type:way` into searchbox and choose "Find in selection" from left-hand menu.

115769750

Dear Mr/Mrs McBlyat,

Judging by the lack of any further complaints I presume reboot has resolved the issue.

All the best, Fghj753

115769750

Dear Mr/Mrs McBlyat,

I'm sorry to hear about difficulties you are experiencing with using changeset visualization tools. That software can be highly overwhelming for a person who has just joined the OSM community. Sadly I was not able to replicate issue you were describing on some of the most common tools.
If you could specify which tools you are using and perhaps share general information about your computer hardware, perhaps we could diagnose the cause of this issue and maybe even find a solution to your problem.
For starters, let's begin with the most common troubleshooting step of most computer issues: have you tried turning it off and on again?

Best regards, Fghj753

115775114

Nicely done, welcome to OSM!
Three things to note:
1) I don't know how familiar are you already with OSM data schema, but OSM uses pairs of key and value (such as building=house). To show that one key has multiple values, people usually use semicolon ( ; ) as separator between those values. That is useful for cases like house-numbers on Village Quarter Road, where you currently used comma ( , ).
2) Don't worry, you have done well, but on right-hand-side of the screen is button with three stacked squares. This is used selecting the map layer. I tried to make small edit on church's parking lot and noticed that both Esri's and Mapbox's imageries have much better quality than Bing, which is selected by default. Take a look at all of them and pick one that provides most recent or highest definition imagery.
3) Thirdly, I encourage you to keep up great work you have done and also suggest you to explore various presets in iD editor (buttons that appear on right-hand side after you have created new object on map). You could make you neighbourhood stand out on map by marking it as residential area, adding grass patches around church or tag Plastic Surgery Center as clinic/other healthcare provider.