Why are you deleting this golf course?! There needs to be a better explanation than just "The Diplomat" in your changeset comments. If you need to "improve" the course, you need to keep the existing features whenever possible to preserve history. Thanks.

Hi Haggardlyforte,

I've gone ahead and reverted this change in changeset/162441660 and wanted to let you know why.

The existing features that you added "golf=fairway" to are part of something called "multipolygons". They combine things like fairways and greens together to indicate that everything that isn't a green/bunker/etc is part of the fairway. To go back and label the piece that defines the "outer" boundary of the multipolygon incorrectly as it says that *everything* within that border is a fairway. Hope this helps. Please let me know if you have any questions.

"This feature has been labeled as deprecated. The recommended replacement is: railway=station mapped as an area."

That's from the Tag:railway=facility wiki. I'd like to see someone replace the facility with a station area to preserve some of the history instead of adding a singular node.

"A railway station is a node."

Well, that's not entirely correct. A railway station can be either a node or an area. It can be a relation, but only a multipolygon relation.

I think a station node might be warranted here, but I'm not sure what the correct way to handle that and the railway facility without doing more research.

Edits that contain large numbers of objects spreading across the entire country with an unhelpful description of just "." are highly frowned on. Please keep your changes more local and provide a better description of what you're changing. Thanks.

Thanks for adding golf courses to OpenStreetMap. We appreciate your contributions.

Here are some bits of advice to make your golf course mapping even better:
◉ Fairways and greens boundaries should never intersect each other. If there is a fringe around the green that is similar to the fairway,
* the fairway should extend around the green and the two objects should be merged together into a multipolygon (See
* osm.wiki/Relation:multipolygon for how to create them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be shared (don't draw nodes for each that might overlap or leave gaps.)
There are some more bits of advice if you care to read over the golf mapping wiki: leisure=golf_course#Common_mapping_pitfalls

Hi DThos,

When mapping fairways and greens, please don't reuse nodes between the green and the fairway when the green is inside the bounds of the fairway. If there is a visible "fringe" around the green, you should represent that fringe by leaving a gap between fairway and green. The two features should also be merged into a multipolygon by selecting both and selecting Merge after right clicking on them.

See the following for more information on mapping golf course features: leisure=golf_course#Common_mapping_pitfalls

thanks.

Oh, another problem is deleting an object when you want to start from scratch. It's much better to modify the geometry of an object instead of just getting rid of it (and more importantly, it's history). If it is difficult to see, try the "W" keyboard shortcut to turn on "wireframe" mode and get rid of some of the shading from the existing feature that obscures background imagery.

Hi Calvin,

Thanks for adding golf courses to OpenStreetMap. We appreciate your contributions.

Here are some bits of advice to make your golf course mapping even better:
* Don't give names to tees, fairways, greens, etc. unless they are explicitly named. The proper way to number something like a fairway is a "ref=18" tag instead of a "name=Fairway 18".
* It would be helpful to me (and others) if, when the fairway completely surrounds the green if you could select the fairway and green and combine them into what's called a multipolygon. There is a "Merge" option with a "C" shortcut to combine them. Just hold down shift and select both objects.

There are some more bits of advice if you care to read over the wiki: leisure=golf_course#Common_mapping_pitfalls

Nice to see there are others out there doing similar golf course cleanups as I'm doing. I've put together some tools to build MapRoulette challenges of fairways and greens that intersect. Let me know if you'd like me to generate a dataset for your area to make them easy to find and fix.

Yeah, I'd love to get more people involved. I created a maproulette challenge and I need to get more people involved. There are 20,000+ fixes that I want to see made and I can't possibly do it all myself.

For reference: http://mpr.lt/c/50926

Can you tell me more about the #GolfCleanUp hashtag? Is this an organized thing or just something you tossed into your comments? Thx

Thanks for going back and fixing them up. Much appreciated! I'll be sure and point out any other issues I notice.

Great looking golf course edits there Jraps. Thanks.

If you're looking for other ways to improve them, you could combine the fairways and greens by selecting the fairway and then holding shift while selecting the green and then press 'c' to "Merge" them into a multipolygon whenever the fairway wraps completely around the green.

Hey there Haggardlyforte, I just wanted to reach out and let you know that I reverted this change. The features that you modified were already correctly tagged as they are multipolygons and the combination of the fairway EXCLUDING the green was tagged as fairway. Your change said everything inside the fairway polygon INCLUDING the green was to be considered a fairway.

Check out this wiki for details: osm.wiki/Relation:multipolygon#Usage

This one too: leisure=golf_course#Common_mapping_pitfalls

Please feel free to reach out if you have any questions. Thanks!

Hi there NK,

Thanks for helping to clean up this golf course. I wanted to point out a small problem what the change you made with the fairway and green that intersected at the north end of this change.

If you take a look at the images in this wiki page: leisure=golf_course#Common_mapping_pitfalls ...
you'll see that the fairway should either butt up against the green or wrap around it (with a gap for the fringe). You wrapped around the green but shared nodes and that will cause problems with editing software (JOSM is one I know of) that doesn't allow that type of construct.

Thanks
---

Published using OSMCha: https://osmcha.org/changesets/162114092

Thanks for the help!

Thanks!

Removed (your?) names to follow OSM best mapping practices and private information practices:

osm.wiki/Mapping_private_information

There are several problems with this changeset and I'm guessing you probably make similar mistakes in others as well.

First off, thanks for helping to improve the map. We appreciate the extra help, but we also need to all follow standards of good mapping behaviors so we can work well together.

An important webpage to read is leisure=golf_course#Common_mapping_pitfalls

Three things I've picked out:
* you are deleting other people's existing golf course features and drawing your own from scratch, destroying history
* you are drawing lollipops instead of using proper multipolygons
* your fairways and greens are overlapping instead of surrounding the greens with a multipolygon or abutting them together.

Please fix this up soon. Thanks.