b-jazz's Comments
| Changeset | When | Comment |
|---|---|---|
| 179953842 | Thanks for going back to clean up. Much appreciated. I did find a couple of near-fixes that you should be careful of going forward. See the area around node/10274269213 for an example of a fairway still crossing a green. thanks again for your attention to this. |
|
| 179927648 | Please make sure fairways and greens don't intersect/overlap. Same can be said for the various other golf areas as well (tees, bunkers, water hazards, etc) |
|
| 179510339 | RE: way/1486374280 et al Thanks for helping map golf courses. There are some problems with your edits however and your mapping process needs to be fixed going forward so you don't continue to step on the efforts of others. For starters, you should read the following wiki: osm.wiki/Keep_the_history on how important it is to *not* delete map elements when you should be modifying them instead. You break multipolygon relations when you delete something like a fairway that belongs to a relation only to redraw it and not properly add it back to the existing relation. You should also read the golf_course wiki (leisure=golf_course#Common_mapping_pitfalls) and the general wiki on how to properly work with multipolygons (osm.wiki/Relation:multipolygon#iD). Thanks. |
|
| 179872823 | Can you please go back and clean up all your fairways. They should not intersect or overlap with the green like you've done many times of the last few changes. Thanks. |
|
| 179797546 | RE: way/1488525955 When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions about golf course mapping, feel free to reach out. |
|
| 179822414 | Be careful marking out "rough" areas. They shouldn't extend deep into the trees. They also shouldn't intersect/touch other golf areas (like fairways and tees). Thanks. |
|
| 178501893 | Please stop breaking golf courses by removing the multipolygons. What you are doing is not correct and is not appreciated when I have to come back over your changes and fix them up again. If you have problems with this, let's discuss it. Maybe I can help you understand your error. Thanks. |
|
| 178683904 | There's a gray area on when mapping a golf rough is really worthwhile. I couldn't find any difference between the grass inside your rough areas and outside your rough areas. Probably best just to leave them out at that point. |
|
| 178428455 | FYI, you don't need to put "area=yes" on a fairway. |
|
| 179670521 | Thanks for helping map golf courses. There are some problems with your edits however and your mapping process needs to be fixed going forward so you don't continue to step on the efforts of others. For starters, you should read the following wiki: osm.wiki/Keep_the_history on how important it is to *not* delete map elements when you should be modifying them instead. You break multipolygon relations when you delete something like a fairway that belongs to a relation only to redraw it and not properly add it back to the existing relation. You should also read the golf_course wiki (leisure=golf_course#Common_mapping_pitfalls) and the general wiki on how to properly work with multipolygons (osm.wiki/Relation:multipolygon#iD). Thanks. Also, the fairway you added crosses over the green at one spot, where the previous one didn't. Please fix that as well. Thanks. |
|
| 178880332 | Check out https://imgur.com/a/J455xMc That's a pretty drastic change in the shape of that water hole and I wasn't sure which one was newer, so I grabbed a couple of different sources (Bing vs. Mapbox, I think). I think the way it is currently drawn might be using older imagery. Thoughts? |
|
| 179470830 | way/1487044185 still has a `golf=fairway` tag, which duplicated that tag on the relation/20304786 relation. Semi-related side note: as you appear to be doing a lot of mapping, you might want to consider learning JOSM to do editing. It is so much easier to understand relations, once you get the hang of using JOSM. It's worth the time invested. |
|
| 179470830 | One example is way/1483289987/history. And my apologies for the form-letter text above. You didn't come across something that existed, but that is very common so it is how I wrote that notification text. You create a fairway multipolygon and tagged the relation correctly, but then you also added the fairway tag to the outer way as well. This was true for several fairways and roughs as well. When part of a relation, the fairway/rough tags go on the relation and not on the outer way. Does that help clear it up? Please let me know so I can refine what I'm saying. It isn't a simple concept, but it's important. |
|
| 179470830 | You have made a common error when you saw a fairway that looked like it didn't have a proper "Feature Type" defined and decided to add the fairway tag. The hole was already properly tagged, but was part of a relation of multiple objects known as a multipolygon. Please read this short wiki page where I've tried to explain what you are looking at and avoid making the mistake in the future. osm.wiki/ID_understanding_golf_course_relations Thanks. |