Check out https://imgur.com/a/J455xMc

That's a pretty drastic change in the shape of that water hole and I wasn't sure which one was newer, so I grabbed a couple of different sources (Bing vs. Mapbox, I think). I think the way it is currently drawn might be using older imagery.

Thoughts?

way/1487044185 still has a `golf=fairway` tag, which duplicated that tag on the relation/20304786 relation.

Semi-related side note: as you appear to be doing a lot of mapping, you might want to consider learning JOSM to do editing. It is so much easier to understand relations, once you get the hang of using JOSM. It's worth the time invested.

One example is way/1483289987/history.

And my apologies for the form-letter text above. You didn't come across something that existed, but that is very common so it is how I wrote that notification text.

You create a fairway multipolygon and tagged the relation correctly, but then you also added the fairway tag to the outer way as well. This was true for several fairways and roughs as well. When part of a relation, the fairway/rough tags go on the relation and not on the outer way.

Does that help clear it up? Please let me know so I can refine what I'm saying. It isn't a simple concept, but it's important.

You have made a common error when you saw a fairway that looked like it didn't have a proper "Feature Type" defined and decided to add the fairway tag. The hole was already properly tagged, but was part of a relation of multiple objects known as a multipolygon. Please read this short wiki page where I've tried to explain what you are looking at and avoid making the mistake in the future. osm.wiki/ID_understanding_golf_course_relations Thanks.

Thanks for the golf course work you are putting in. In the future, please avoid deleting an object only to recreate it later. It destroys history of the object that might be important. It's always best to modify an object. It's not always possible, but it should be preferred. See osm.wiki/Keep_the_history

Thanks.

You have made a common error when you saw a fairway that looked like it didn't have a proper "Feature Type" defined and decided to add the fairway tag. The hole was already properly tagged, but was part of a relation of multiple objects known as a multipolygon. Please read this short wiki page where I've tried to explain what you are looking at and avoid making the mistake in the future. osm.wiki/ID_understanding_golf_course_relations Thanks.

See node/13622035786 for an example of overlap.

(Within the US, that is.)

Thanks. Your help is appreciated. After spending 3 years cleaning up tens of thousands of golf courses, I find it hard to believe you found examples of fairways and greens that overlap. Can you give me some examples where this is happening? Thx.

RE: way/762941613

When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions about golf course mapping, feel free to reach out.

Thanks for fixing!

Please make sure golf course elements like fairways don't overlap each other like you've done on the 17th hole. Thanks.

Please make sure that golf course elements like fairways, greens, and bunkers don't intersect/overlap each other like you did with the green here. Thanks.

Not to mention your edits are a bit sloppy in that the fairway is crossing over the green. It should never do that.

This looks like an automated edit of some sort. I've seen several of these nodes now that have the website tag value be messed up and look like this: "/url?q=http://citycafeamarillo.com/&opi=79508299&..." instead of simply "http://citycafeamarillo.com/"

Please review your recent changes and fix all of these incorrect website tags. Thanks.

RE: way/1127501566

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green along with the right way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

Thanks for the report. I can’t confirm these so I don’t typically make edits suggested in comments. Off you want to make the change yourself, please feel free. You can find more information at https://learnosm.org

Also, when you create a multipolygon relation with a fairway and a green (or various other combination of inner ways), you should tag the fairway way as fairway as you've already tagged the relation with inner/outer ways as a fairway. To also tag the outer way is wrong. thanks.

FYI, I fixed up a bunch of golf=hole ways that you had done recently. Please be aware that direction matters and the way should be drawn from the pin to the hole/green. Hopefully I found them all, but I just wanted you to be aware for your golf course map that you contribute to. thanks.

I fixed up the tee boxes that were overlapping with the fairways. Please make sure that they don't cross over each other, even if only a centimeter over. Thanks.