OpenStreetMap logo OpenStreetMap

Changeset When Comment
170253585

Hey Corey,

I'm going to try making a video to better explain this error and how it crops up. The short answer is, if you see something like a fairway that doesn't have any tags, don't be tempted to add a "golf=fairway" tag to it if it belongs to a relation. You'll notice that the relation has that tag already and to add a fairway tag to just the one member of the relation (the fairway), it messes up the meaning. Thanks.

170259884

RE: way/1421400152

As mentioned previously, fairways and greens (and other golf areas) must not have boundaries that cross over each other.

Please see changeset/169083805

170131411

RE: way/1420847505, et al

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green along with the right way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. Thanks.

170139456

(On deeper inspection, I see that you were just removing extraneous dense nodes and you weren't the original created of the crossing of the fairway over the green. So you can ignore the comment above (unless you're interested in cleaning it up anyway).

170139456

RE: way/1088041689

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green along with the right way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. Thanks.

169982979

I don't have a good answer for that. It depends on how much you want to be involved. I'm not that familiar with tagging areas that are abandoned and under construction, but do know that some tags exist to indicate that. You should check osm.wiki and see what you can find there. If you don't take care of it yourself, I'm sure someone will redraw it eventually. That's the joy of mapping in an ever-changing world.

169982979

Hey Whippy, thanks for responding. I get that things might be in flux while you in the middle of a project. It would be beneficial if you could find another way to indicate progress other than introducing errors into the map though. Maybe a "note" tag or "todo" tag.

Sorry if you other comment was confusing. I come across a lot of these and have made the comment as generic as possible while still trying to get the point across. The comment in this case was specifically because the fairway border cut right through the bunker, and that's not right. I see that you've corrected it now. Thanks for doing that!

169982979

Also, you shouldn't be giving a name to a bunker like "Sand Trap". That is redundant with the tag of "golf=bunker". And the nearby green shouldn't be named "#4 Green". If you want to include the hole number on the green, you can do it with a "ref=4" tag, but naming a green shouldn't be done here.

169982979

RE: way/1420091425, et al

When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out.

169986311

RE: way/279588495

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. When drawing these shared nodes, editors like iD will "snap" to an existing node if you get close enough. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. Thanks.

169879624

RE: way/1419444981

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. When drawing these shared nodes, editors like iD will "snap" to an existing node if you get close enough. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. Thanks.

169788784

The water hazard that you created along the 18th hole overlaps with the bunker at the north end of the hole and the rough just below that. Please correct your water hazard or the bunkers/roughs so that they don't overlap. It's fine if they share nodes, but overlapping is no good. Thanks.

169749002

RE: way/1418821742

When you mapped the driving range in the URL above, you used something called "lollipop" mapping and that is the wrong way to represent what you're trying to map here. The right way to handle this (in the "iD" editor) is the draw the outer boundary for the fairway/driving-range, and then draw all the elements inside, and then select them all and "combine" ("merge") them into a multipolygon relation. Thanks

169784556

RE: way/874403301

Hey there Corey,

I just wanted to reach out real quick and let you know that shouldn't have added the fairway tag to the High Knoll hole. The hole is structured as a "multipolygon", meaning that there are multiple piece that define the shape of the hole. In this case, there is an outer boundary around the entire fairway, combined with and excluding the inner boundary of the green. I've fixed this, but wanted to let you know in case you came across a similar hole.

169647551

RE: way/892128195

As mentioned in my previous comments on a change you made, the lines that define fairways and greens must not cross over each other like you've done here at the green/hole named "Beginning" and "Double Green". Please make sure you clean those up and refrain from cross golf course areas like this in the future. Thanks.

169587938

RE: way/1417972338

Hey there Matub,

TL;DR You're missing a couple of shared nodes when you draw the boundary between the green/fairway in the above-mentioned link. Please make sure every node is shared. In this case, you missed node/13030728744 and triggered a Q/A check.

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. When drawing these shared nodes, editors like iD will "snap" to an existing node if you get close enough. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. Thanks.

169618585

dang it!

169622946

sorry

169486199

RE: way/1417411338

Hey there dscott,

I've noticed this error several times in the past couple of days and wanted to bring it to your attention. You are doing a great job of sharing nodes between the fairways and the greens, but you will sometimes miss a single node (node/13025446812 in this case) and that will cause Q/A tools to flag that as an overlap and needing attention. Can you be extra careful and make sure all nodes are being shared and none are left out? Thanks!

(If you ever want to learn a more advanced tool like JOSM, you'll find that it has tools that make drawing of shared lines a breeze and will save you a lot of time. Reach out if you ever want to know more about that.)

169524343

RE: way/1417600792

When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens, bunkers, tees, or other golf course areas for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out.