OK, cool. Just wanted someone to be aware. Should I at least move it closer to the water and maybe at a fixme tag?

RE: way/798162746

And when you go around the green, please try to match the level of detail/refinement of the original green. This green is rather well defined but the fairway going around the fringe uses only around a dozen nodes. Thanks.

RE: way/795834984

It's great that you're cleaning up some golf course errors, but you are causing further cleanup tasks down the road. If you are going to exclude the green from the fairway, you at least need to butt the fairway up to the green and share all of the nodes in between. See the golf_course wiki for some examples: leisure=golf_course#Common_mapping_pitfalls

Thanks. If there is anything unclear, please reach out and let me know.

Please make changes over smaller areas. You destroyed the area around PNC Park and made it difficult to revert those changes.

Heh. You can see my bot changed something nearby and the name shows up at the bottom of his OSM window at that timestamp.

So yeah, we know about this guy. He's been banned from OSM for putting out bad information and refusing to correct it. He's even turned off comments on the video so people can't add something along the lines of "hey, don't do that thing he talks about at 9:43 in the video. Do this instead..."

How did you come across the video? Just a google search or did something from TGC lead you to it? Maybe we can address it further up the chain.

Thanks for the response.
Could you send me a link to the tutorial? I'm pretty sure we are aware of it and have tried to get the creator to amend it or somehow get the correct information out. But just in case, I want to make sure we cover all bases and address each tutorial that might lead people down the wrong path. Thanks.

node/12090867003 seems slightly out of place, being in the middle of a golf green and all. I'm assuming it is supposed to be by the nearby water feature.

RE: way/1375030597

Please don't share the nodes of the green if you have the fairway surround the green. If you can't see any fringe around the green, you should make the fairway butt up to the green and share the nodes on the boundary between the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please let me know and I'll gladly help clarify things. Thanks!

Please don't share the nodes of the green if you have the fairway surround the green. If you can't see any fringe around the green, you should make the fairway butt up to the green share the nodes on the boundary between the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please let me know and I'll gladly help clarify things. Thanks!

Please don't use the "lollipop" style of mapping golf course elements as seen in way/931454583. You need to create proper multipolygon relations in order to map features like roughs/bunkers that are within other features like fairways. Please see leisure=golf_course#Common_mapping_pitfalls and osm.wiki/Relation:multipolygon for help in understanding how to map this situation. If those aren't clear, please let me know and I'll help explain them further. Thanks.

Why did you change the first hole on the golf course?

Thanks for reverting your changes. FYI, the bunker belongs in the multipolygon as well.

Can you explain this a little more. There is nothing wrong with fairways "overlapping" greens when they are properly defined with multipolygon relations. There is a fringe around the green and that is typically mapped the way I had had mapped it. It would be nice if you didn't undo all of my hard work. Maybe I'm missing something.

I really wish JOSM would prevent you from doing changeset areas without forcing you to confirm it first. It notifies you, but that isn't enough if you're in a groove.

I should expand that to say that fairways should also not be crossing bunkers, water hazards, and tees and other golf features. See way/1373723302 for an example of where you make this error.

Hello golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Hi there. Please stop drawing a bunch of connected or overlapping shaped representing the same area. For instance the rough around this object (way/1373629377) touches several other rough areas.

Thanks malifica. I appreciate having a chance to discuss it and work out our issues.

I am sorry to hear about the performance issues you're seeing. I typically have very fast data loads with OSM (short of rare server issues with OSM) so I'm thinking you might be right that it might be an ArcGIS problem. Have you ever looked into QGIS? It's free and runs everywhere and might help. I have no deep experience with either though.

Somehow word got out early on that the right way to join a fairway and green was to overlap them. This style was quickly adopted and spread like wildfire and we now have 20,000 greens like this and I'm doing my darndest to clean them up and get word out to hopefully stop that flow.

The lollipops I was referring to sound different from what you are doing. I used to run into them often and put together a 3 month effort to get rid of them (at least on fairways). Here's an example of what I'd see: osm.wiki/w/images/5/58/Golf_Course_Lollipop_Example.png

>You do you, I'll do me.

I will follow best practices. The community needs you to do the same. If you make wildly bad edits like running fairways into greens, you'll be called out and will face being blocked. I don't expect you to turn everything into multipolygons. It would be appreciated if you did, but I'm not going to report you for that. But if you break existing multipolygon relations, that's another story. Another problem that the community has is when someone wipes out existing work and replaces it with their own. You should preserve the history of existing objects. Don't delete a fairway and redraw it, just modify it.

There are so many different possibilities for the inners and outers that you list above that it is not worth typing out how it should be done. I'll point you at the (unnamed) course in this changeset that I worked on this morning. Most everything should be tagged correctly now. If you'd like to find an example that you feel is wrong, paste the url of the piece and I'll take a look and discuss further.

I'd like to see an example of the "vastly increase[d] query times". Can you provide me an example query that takes an inordinate amount of time? Maybe the query isn't structured well? I don't know, but until I see it I can't know.

I don't see a "hierarchy nightmare". I see something that makes complete sense logically and is represented correctly geometrically. Yes, you can have a bunker inside a rough inside a fairway inside a rough. It's not that complex. And when you go and use spatial databases and query the area of rough, since everything is correctly tagged and laid out, you get the answer you're looking for.

Don't confuse "unusable" for "poorly implemented". If there is some software isn't written correctly to handle these complex relations, then it is the problem.

As for parent lines that have lost their tag... I've heard of this misconception before. The tag is still there, it is just where it should be: on the relation, and not the outer boundary. I've been meaning to write up a document to give some visual examples of this. Take a simple green in a fairway. The line the defines the outer fairway isn't the fairway. It's the fairway minus the green. And if you look at the relation, you'll see the outer/inner relation correctly defines that.