OpenStreetMap logo OpenStreetMap

Changeset When Comment
136091078

> Also, do you still think that it was an undocumented bot edit?

Yes, in the sense that you wrote some documentation saying what you were going to do and then did something else instead. To be honest, I have re-read osm.wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account/fixing_malformed_shop_tags and I still struggle to understand exactly what you are trying to say. I presume that "Please write at bot approval thread." means "please reply on the mailing list" to prevent part of this change from occurring" I did that and you ignored the request. By that definition it is surely an undocumented mechanical edit.

136091078

To be clear, what I'm suggesting is that if you _really_ care about having correct values in OSM then a tiny bit of research will often yield correct values. https://overpass-turbo.eu/s/1v53 is the set of your recent changes over a widish area. Many of the items that that finds can be easily found: node/441917983/history is clearly https://www.the-stone-shop.com/ for example, and of the in-use tags at https://taginfo.openstreetmap.org/keys/shop#overview perhaps https://taginfo.openstreetmap.org/tags/shop=gemstones is the best bet.
node/658618239/history is pretty obviously https://www.facebook.com/raysdiscountstores/ , and looks like a https://taginfo.openstreetmap.org/tags/shop=variety_store to me.
Changing these to shop=yes means that they get lost in https://overpass-turbo.eu/s/1v54 , which means that they will just get ignored, like the other 180k examples.

136091078

(just to be clear - here we are talking about anything to shop=yes, not just shop=fixme)

If you've removed it from the wiki page, are you going to undo your changes?

136091078

Your basic errors were:

Performing an undocumented mechanical edit (the text at osm.wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account/fixing_malformed_shop_tags does not cover this case).

Thinking that changing "rare tag I do not understand" into "common but meaningless tag" added any value.

Continuing with these ridiculous edits despite being told that they were damaging (and after you yourself had reverted previous examples after previous complaints!).

Not using any common sense when trying to work out what a sensible value might be. Did you ask anyone? No. Did you investigate? No (a search locally for shops with the name Lighthouse will find a number of "Lighthouse Charity Shop" examples).

I can guarantee that a mention on IRC that you were going to change a shop in Nottingham with the name Lighthouse into a nondescriptive value would have got an immediate response.

136075427

Did you even read https://lists.openstreetmap.org/pipermail/talk/2023-April/088189.html ?

136091078

As I have said on the mailing list already, local knowledge. Also, as I have also said on the mailing list, a quick overpass search finds lots of other similarly named shops tagged as "shop=charity" nearby.

I could forgive a completely new OSM contributor with making this kind of basic error, but am genuinely saddened that someone with your level of experience with OSM is making these kind of basic mistakes.

136075427

Note for the avoidance of doubt that the change here is NOT documented by osm_wiki_documentation_page osm.wiki/Mechanical_Edits (there is no mention of fixme on that page) despite a changeset tag suggesting that it is. This is essentially an undiscussed mechanical edit.

136075427

> , but it is also not worse than before.

untrue.

A new "shop=yes" will just get lost in the other 180k "shop=yes". We know they won't get spotted because the other 180k of them have not been.

Updating something that you do not even know exists with a "new" value means something that looks at the last modified date might think that it has been verified recently when it has not.

Your actions here are making it harder for local mappers to improve the quality of data in OSM. You should stop now.

136211919

Hello,
I can probably guess "SAU" (Saudi Arabia) and "YEM" (Yemen) here, but what are "GHSL" and "EC" here? "add villages and details" is of course perfectly descriptive.
Best Regards,
Andy

136178146

(although how "Egypt" is relevant to a change in Oman I have no idea)

136178146

Please, using meaningful changeset comments. Assuming that "#EGY" here actually means "Egypt", why not use that one extra character and have people understand what you mean, as opposed to not doing and leaving them guessing?

136075427

Are you sure that node/2361007180/history is still a shop at all? What action did you take to verify it?
If none, how does what you have done here improve the quality of OSM?

136091078

Clearly the change to e.g. way/353944525 is causing information to be lost here (not much information, but still something).
The correct tag here would be "shop=charity".

136019418

With node/6813245577/history it might make sense to talk to the original contributor. Clearly shop=yes is not a good replacement here.

136080045

You've replaced a few like node/6590059464/history , but is the replacement here perhaps less precise?

136024897

A heads-up might have been nice here. Do the subtags need on node/1178915529/history need to be changed or discussed anywhere?

135290950

See osm.org/user_blocks/7131 .

136128234

Oh dear. See See osm.org/user_blocks/7131 . .

136117309

Thanks

126393879

Alas, the "East Riding" added as a subarea to the traditional county of Yorkshire here is the wrong one, it's the modern unitary authority relation/88083 , noth the old Riding which way/56150279 would be on the boundary of.