SafwatHalaby's Comments
| Changeset | When | Comment |
|---|---|---|
| 52162459 | See the discussion at: changeset/51350214 |
|
| 52162366 | This changeset did not behave as expected. It was supposed to add brand:wikidata and operator:wikidata. Also, it only touched nodes and not ways. I was followed up with a fix: changeset/52162459 |
|
| 52155033 | Again, note the building squaring thing. Also, you have two roads on top of one another. first: way/525700809. Second: way/525700808 |
|
| 52154853 | You requested a review. The name tag is usually used to describe the literal name (e.g. what you see on a sign). To describe the type of a building, use building=warehouse rather than building=yes, and leave the name blank. See this: building=warehouse |
|
| 52155367 | Welcome to OpenStreetmap! You requested a review. 1. Your buildings do not have 90-degree angles. You can create perfectly square buildings by right clicking them and then clicking "square". 2. Some of the roads you added are disconnected from the main grid. This makes them impossible to navigate for GPS programs. See this road: way/525703432 and this one: way/525703434. You need to connect them to nearby roads. Thanks for your contributions and happy mapping. |
|
| 52145782 | It appears those lead to sensor data. Perhaps the "image" tag should be renamed to "website" or some new tag. "image" is for images. |
|
| 52145782 | Those image and "dataset" links are very strange. Mind explaining? |
|
| 52145167 | Please square the building (right click, then square) |
|
| 52145472 | Please square the buildings (right click, the click "square") |
|
| 51996451 | working > wording* |
|
| 51996451 | Also, I think the Wiki might use some re-wording. I think the idea behind that working is to have Hebrew in most of the places, and Arabic for Arabic towns or villages. |
|
| 51996451 | How is that? Do most people speak English in מכון וייצמן? |
|
| 52119602 | access=customers implies motor_vehicle=customers. No need for the latter. |
|
| 52119429 | That seems overkill. Access=private implies everything else is private unless stated otherwise |
|
| 52099837 | I am not quite sure what you mean by "symbols" here, but I also made sure the dome of the rock has an Arabic "name" tag whilst the other two structures have a Hebrew "name" tag. |
|
| 52099837 | Sorry but your last edit made it even more confusing. The dome of the rock is not the same as:
I've changed it back to the way it was, plus I removed the word "synagogue/masjid" and added religion=muslim to the dome, and religion=jewish to the "hekhal" and "holy of holies". Please let me know if there's still a problem. Also, please check this out: https://en.wikipedia.org/wiki/Holy_of_Holies |
|
| 51350214 | Thanks! I also think this should be adopted globally, but I still need to polish/simplify the code a bit first. The bot makes assumptions that are agreed upon only in Israel and there's special treatment for some tags like name/operator. Making it global requires a bit more work. Most people don't add the Wikidata tag, so right now the bot tracks many tags like brand/name/operator to track POIs. I could make it track using the wikidata tag if it's present and fall back to other tags otherwise. |
|
| 52099837 | Hi and welcome to Openstreetmap. I think your Dom of Rock edits are invalid. This place has 3 structures.
You renamed "Holy of Holies" to "قبة الصخرة" and now the map has two domes of the rock. You also removed the "jewish" tag from the two structures. Would you mind if I fix this? |
|
| 51469993 | Reverted in changeset/52098819 due to lack of explanation |
|
| 51431708 | ...and changeset/51992698 |