Lee Carré's Comments
| Changeset | When | Comment |
|---|---|---|
| 118442456 | Among many other questionable changes, node/9576047159 is incorrect (see note/2715887 ). Don't be osm.wiki/Tagging_for_the_renderer (or guessing). Instead: emergency=emergency_ward_entrance |
|
| 118442904 | Much smaller changeset areas, please: osm.wiki/Changeset#Geographical_size_of_changesets |
|
| 118442456 | Smaller changeset areas wouldn't go amiss, either: osm.wiki/Changeset#Geographical_size_of_changesets |
|
| 118442456 | “Jersey updates” What, exactly? To locals, this is meaningless. What makes for osm.wiki/Good_changeset_comments. |
|
| 95086149 | http://www.camerons.je/news/article/bath-street-re-development |
|
| 95086149 | http://www.camerons.je/projects/current/all/project/bath-street-re-development |
|
| 95086149 | http://www.lemasurier.co.uk/news/proud-present-merchants-square-new-development-centre-st-helier/ |
|
| 95086149 | ||
| 118435103 | “Large bbox because the country relation spans both hemispheres.”
Those damn Vikings invading & conquering everywhere(!) 😋 |
|
| 118399529 | Self-corrected: changeset/118422695 |
|
| 118402186 | Self-corrected: changeset/118422695 |
|
| 118410656 | Self-corrected: changeset/118422695 |
|
| 118422695 | 👍 |
|
| 118432831 | [comment=…] “, etc” I noticed that you also added some trees (e.g. node/9575346745 ). It is better to mention each type of change in your changeset comment. You don't have to do everything in the same changeset, in the same area (separate changesets is probably better).
Each with a specific, descriptive comment. 🙂 |
|
| 118432831 | Hello. Welcome to OSM. Thankyou for your efforts to improve the map. Because you're very new (changesets_count=1 🙂) and want a review (review_requested=yes); some tips for you: Firstly, you should complete the tutorial within iD (the editor you used). Secondly, it is preferable to make smaller changesets. See osm.wiki/Changeset#Geographical_size_of_changesets
Review & verification is a significant part of OSM. Large changesets make that difficult. Another problem with large changeset bounding-boxes (the area covered by all included changes) is that they appear in the list of mappers monitoring their local area, because it spans half the planet. Smaller areas will avoid this. Many small changesets means that you can type a specific descriptive comment for each, rather than trying to describe everything in one.
More generally, there's a lot of advice for newbies at osm.wiki/Good_practice (with links to specific advice on each topic). Good points:
… “Marcamos casas, desmarcamos edificios, etc” http://mymemory.translated.net/en/Spanish/English/Marcamos-casas%2C-desmarcamos-edificios%2C-etc = ‘We mark houses, unmark buildings, etc.’ Ah! You added (traced from imagery) several building=house outlines, and separated buildings (probably related to the resolved warnings about intersecting buildings). 👍🥳
Overall, a good first changeset. Just remember that “Save” button 😉. |
|
| 118386162 | Actually, if (as you said, SomeoneElse, in another changeset discussion) Osmose is not a source in its own right, and only to be used as a reference in combination with real sources (imagery, survey, whatever), then why is it even possible to submit changesets from within Osmose itself? If other sources are required, then that implies needing a non-QA editor (iD, Vespucci, JOSM, etc.). |
|
| 118386162 | Although I agree that users are responsible for changesets made under their account, I think (part of) the problem is that the metadata is generated by Osmose itself (hence being nondescript), without the possibility of modifying it (which probably warrants a bug report). I see many changesets, by various users, with identical metadata (or, identical changeset tags, at least). For andrewpmk:
|
|
| 118410656 | Seems that this isn't the only changeset making similar changes, by this user. Some are even more recent. |
|
| 118404839 | Hello. Welcome to OSM. Thankyou for your efforts to improve the map. Since you're very new, some pointers. “updates with local knowledge” While I take it that source = local knowledge (but that should be specified with the source field, itself (see source=* )); what was updated, where, how, why? What makes for osm.wiki/Good_changeset_comments Also, much smaller changeset areas, please: osm.wiki/Changeset#Geographical_size_of_changesets
More generally, you may find it helpful to read osm.wiki/Good_practice |
|
| 118249424 | iD repo triager confirmed my suspicion, so I opened http://github.com/hotosm/tasking-manager/issues/5038 |