Hi, welcome to OpenStreetMap and thanks for the edit. Saw that you requested some feedback - the changes look good to me, although it perhaps some more info could be added.
For example, if the building is a GP/doctors surgery, the amenity=doctors tag could be added (or search in the editor's preset list).
And a tip for buildings - in the editor if you press S having selected a building it will "square" the corners for you.
If you need any help let me know.
Cheers

Hi, thanks for the edit. I've changed the tags to railway=construction instead of rail as it is not completed yet, and so it doesn't render on the map.

*seem

You seen to have deleted part of the B935 by mistake

Agreed this should be changed back to trunk as I don't think it's officially a motorway on the ground, despite what the source website says?

Stray node: node/5072236731 don't know if it's meant to be something?

Did you delete the road continuing north by accident or has it really been removed? way/435021428

Hi, I've changed the rest of the C21 to tertiary as you had left some of it as unclassified from here way/416229200

Hi, welcome to OSM and thanks for the edit. I've added the shop=jewelry tag so it appears on the map as a jewellers.

Why did you remove amenity=school from way/26654202/ ?

Hi. Not sure why you added these contour lines, will you be removing them shortly?

Hi Gordon, you'll need to connect this path to both of the roads as just now it's an unconnected island :)

You've managed to delete a section of coastline east of Dundee. It'll need to be added back or this changeset will require reverting. Also, normally the MHWS is marked using the blue line in OS StreetView OpenData background layer.

Isn't node/4694363660 better tagged as shop=opticians?

What effect were you looking to achieve?

Perhaps it should also be tagged as tourism=guest_house if it is indeed a guest house/b&b?

How does way/206875957 cross the railway line? Via a level crossing or a bridge/tunnel?

Did you not notice this area was marked as brownfield? way/7917034/history The building no longer exists and new housing is being built in this area. I know it looks obvious from Bing imagery but please check the area to see why no buildings are mapped! :)

Thanks for the reply. The problem now is that the name is not rendered on the standard map! :)
All of the suburbs in Edinburgh are mapped with a node and area. I agree that a solution needs to be found with place areas and a label node.
I will revert this changeset to put the node back.

Hi, can I ask why you've removed the suburb node? And just wondering if you plan on removing the others from Edinburgh as well?