Why have you removed landuse=residential from these houses?
way/110155754#map=18/51.346672/-2.303921

> it's for staff and signed in visitors only.

So what? It's still an entity in its own right. Add access=* to indicate who can shop there.

> Could map it separately however as a generally mapper from the public it's impossible to keep it up to date.

No. It's status is verifiable from the FHRS database. Giving the shop it own node & tags inside the building is still more accurate & detailed, even if the location within the building is rough guess.

I've started a conversation on Talk-GB.

Your actions exclude & obfuscate valid data.

Failing to give separate companies separate, named entities means that accurate data (such as a list of Tesco shops) can not be retrieved.

This is poor mapping.

> (needs both FHRS id and postcode to match).

Presuming FHRS's addresses are accurate is also poor mapping.

> "you can't go to the school and order some catering."

The tag gives no implication that that is the case.

It's disappointing to see another case where edits reduce the quality of the OSM database. Please pass this on to "the Edinburgh OSM meetup group".

You've still not corrected your duplication: way/465242150

> there is not a separate catering business that you could go to

Then why did you add contact details?

>instead it's an outside contractor

As a separate contractor it requires as separate FHRS.

> potentially as a ; separated list rather than having a separate node for the caterer.

But that doesn't name the catering contractor
The FHRS is assigned to the contractor, not the school.

>I see the tag craft=caterer being the base/office/van of a business that you could go to for eg outside catering, or other venue catering.

The caterer is contracted to multiple venues each with its own FHRS therefore requires a separate tag for each venue.

>The FHRS comparison does support having a list of FHRS:ids.

I don't know what you mean by that.