CAM-Gerlach's Comments
| Changeset | When | Comment |
|---|---|---|
| 155999049 | Changeset comment INCORRECT; should be: Add/update service roads, parking lots, foot/cycleways, buildings and fencing from newly-rebuilt Briarwood Pool area in the Hethwood community of Blacksburg, VA. |
|
| 155933922 | Looks good, thanks!
|
|
| 155879844 | Great, thanks! |
|
| 155879844 | Thanks for the update. Shouldn't `opening_date` be preserved as `start_date` rather than deleting valid information from the map?
|
|
| 155675928 | Oops, sorry about that! Thanks for the catch; I'd checked the wiki and taginfo before as usual but saw very low usage (only a few hundred hits) of the correct tag and none of my many validators flagged the incorrect one, so I didn't realize I'd made a mistake and not entered it correctly the first time, which then propagated to the others. I've fixed it in changeset/155850997 changeset/155850997 |
|
| 155715498 | Thanks. Would it make sense to fix the bad previous name tag to old_name=Mish Mish rather than removing it entirely? Or is it just _too_ old to be relevant now?
|
|
| 155715403 | Also left a comment on the original user's changeset, so this is brought to their attention to keep in mind for the future. |
|
| 155604661 | FYI, this mistakenly removed node with still-valid details (e.g. addr:*); reverted in changeset https://osmcha.org/changesets/155715403?aoi=15aa7c6a-52b1-4bb0-a810-81319c87415b
|
|
| 155715403 | Thanks! And also ""Be brave in what you add but careful in what you delete", i.e. not removing valid, in-scope detail from the map when making changes (e.g. addr:* tags here), e.g. osm.wiki/Good_practice#Don't_remove_tags_that_you_don't_understand
|
|
| 155344954 | For some guidance, in the Blacksburg area I've found the following uses for the available imagery: - VBMP for primary work (newer, moderate resolution, lower tree blockage, needs alignment)
To align VBMP (to Bing, which closely matches GPS traces and is well-aligned at high zooms), I use the following imagery offset: -0.67;0.82 |
|
| 155344954 | Additionally, I suggest (and implemented) the following changes, mostly similar to the previous: changeset/155448900 - These days, the source tag Source should generally be set on your changeset itself rather than specific objects, as it is a property of your specific changeset and not anything inherent to the object itself (for example, someone like myself might later update the object using e.g. aerial imagery, making the source out of date)
|
|
| 155344954 | Good job here! Just a few suggestions and tips, with the main one being: With recently-constructed buildings like these, its a good idea to check all available imagery to see which is the most up-to-date. Esri Clarity (which the imagery tag on your changeset indicates you used) is often some of the oldest (though some of the best quality, depending on region) and just shows a greenfield, as does the somewhat newer Bing. VBMP, while lower resolution, shows the construction site, while NAIP actually shows the building outline. This allowed me to trace the building, and transfer your tags to it from the node. To help preserve the history, I moved your original node to be the top-left corner of the resulting building.
|
|
| 155344380 | Looks good! The only changes I might consider are adding a few more (entirely optional) basic details from the linked website (phone number, and ideally fax and opening hours as well), addr:country since other local addresses use it, and tagging the building the POI is in appropriately (building=commercial in this case). I've implemented them in my changeset: changeset/155448900 But again, all those are just a bonus on top of what you've already done—what you have is great! The only other possible thing is that if the vet clinic occupies the whole building (which I cannot tell for sure from the available information as I'm not on the ground), its good to add the tags on the building itself rather than a standalone node.
|
|
| 155344197 | One last tip—OSMCha is a terrific tool for viewing (and reviewing) OSM changesets, as it shows you the actual changes made on the map. You can check out my followup changeset at https://osmcha.org/changesets/155448900 (and feel free to review it, too!) |
|
| 155344197 | Also, a few more specific tips on the details, which I've also implemented in my followup: - Make sure the name of the POI is accurate :) In this case, the name of this POI (per its website that you linked), is Kibbles on Main (plural)
|
|
| 155344197 | Here are some suggestions to level up your OSM-fu further! I've implemented all of these in the followup changeset changeset/155448900 - If you've confirmed "on the ground" that this store currently exists at this location, which is the considered the "gold standard" of OSM contributions, make sure to include "Survey" under the Sources field of the changeset (right under the changeset comment in iD), and/or any other sources you've used.
|
|
| 155344197 | Hi Caitlyn, and welcome to OSM! Thanks for your contribution, and for requesting feedback on your changeset. Seeing as your edits are in or near two of the three areas I regularly map, I figured I'd step up and review them! Just to make sure (since it can be pretty unclear for new users), requesting a review just adds a flag to your changeset asking your fellow mappers to give you feedback on it; otherwise your changeset goes live on the map immediately as normal. Overall, looks like a great change! You added a POI with an appropriate type, address and some useful contact details. Thanks!
|
|
| 154874348 | Speaking of which, on a related (heh) note—I see the cycleway along Beamer Way connecting the Huckleberry trail along Southgate with that just north of the airport is part of the Huckleberry Trail route relation, but doesn't have `name=Huckleberry Trail` like the others. Is that an oversight that should be fixed, or is there a reason for that, do you know? Thanks! |
|
| 154874371 | And on that note, I fixed the crossing ways for the cycleway connecting the segment of Huckleberry Trail along Southgate with that just north of the airport to be cycleway rather than footway crossings. |
|
| 154874371 | Gotcha, thanks! It seems my initial confusion stemmed from misreading the wiki guidance to say that cycleway crossings should only be used when cycleway crossings have a legal status distinct from _footway crossings_ as opposed to a distinct status from _plain cycleways_, which is why I initially tagged this (and others) as a footway crossing instead of a cycleway crossing (despite the latter seeming more intuitive). Given both the legal status and also my misread, its clear tagging this as the latter indeed makes more sense, thanks, and I'll keep that in mind for other crossings. |